Hi @Vins,
First I would like to thank you for having reported this point.
In fact, these compilation errors are related to the requirement that the destination buffer be determined by a null character. Indeed, if the length of source string is less than the size n of the destination buffer, strncpy() function writes an additional null character at the end of the destination buffer to ensure that a total of n bytes are written. In order to solve the detected errors, the following update should be proposed:
- For errors N°1, 2, & 3 (Lines 102, 266 & 550) in the AudioPlayerPresenter.cpp file:
- char copy[50];
+ char copy[60];
char unknown[10];
- strncpy(copy, fullname, 50);
+ strncpy(copy, fullname, sizeof(copy) - 1);
- For error N°4 (Line 138) in the AudioPlayerPresenter.cpp file:
The size of the FOLDERNAME_LENGTH parameter could be updated in the CommonDefinitions.hpp file from 40 to 50.
On the other hand, using the strncat() function instead of the strcat() function can resolve other detected errors that are related to the strcat() function. In fact, the strncat() function is similar to strcat() , except that the first one will use at most n bytes of the source string and does not need to be terminated by a null character if it contains n or more bytes. So, the proposed update could be:
- Concerning the error N°5 (Line 476) in the AudioPlayerPresenter.cpp file and the error N°6 (Line 234) in the VideoPlayerView.cpp file:
- strcat(playlist[pl_index].filename, currentFolder);
+ strncat(playlist[pl_index].filename, currentFolder, sizeof(playlist[pl_index].filename) - 1);
I hope the fix I provided you with was helpful. Thank you again for your report. Do not hesitate in case you have other questions.
With regards,
