forever loop bug in stm32h7xx_hal_rtc.c for RTC initialization

[PX]

The function RTC_EnterInitMode in stm32h7xx_hal_rtc.c can cause a forever loop when initializing RTC. The break line is missed as below:

    while ((hrtc->Instance->ISR & RTC_ISR_INITF) == 0U)
    {
      if((HAL_GetTick()  - tickstart) > RTC_TIMEOUT_VALUE)
      {
        status = HAL_TIMEOUT;
        hrtc->State = HAL_RTC_STATE_TIMEOUT;
        break;  <<<<< missed line
      }
    }

This was found occasionally with my STM32H745ZI-Q eval board, which of RTC and LTE were damaged by wrong power connection.

[Pavel A.]

Fixed in the current version:

https://github.com/STMicroelectronics/stm32f7xx_hal_driver/blob/bcfd32d9cd8d0f46c7dec7fc888696e03fc6c9d6/Src/stm32f7xx_hal_rtc.c#L1876

[PX]

Why not fix it in stm32h7xx_hal_driver?

please look closely that you are talking about a different HAL.

[Pavel A.]

Oops sorry. Yes this is a different HAL.

You can report the bug here: https://github.com/STMicroelectronics/stm32h7xx_hal_driver/issues

https://github.com/STMicroelectronics/stm32h7xx_hal_driver/blob/3ba4eb3e14ec1d407c05f5af5665e0eae789bd0b/Src/stm32h7xx_hal_rtc.c#L1958

https://github.com/STMicroelectronics/stm32h7xx_hal_driver/blob/3ba4eb3e14ec1d407c05f5af5665e0eae789bd0b/Src/stm32h7xx_hal_rtc.c#L1976

[Amel NASRI]

Hi @PX​ ,

After a quick review, I don't find this issue tracked in Github.

I'll take care to report it to development team.

-Amel

[PX · Accepted solution]

Confirmed it's fixed in v1.10.1. Thanks.