cancel
Showing results for 
Search instead for 
Did you mean: 

Not able to read or write in flash memory. Not understanding where I went wrong?

SivaP.
Associate II

/* USER CODE BEGIN Header */

/**

 ******************************************************************************

 * @file      : main.c

 * @brief     : Main program body

 ******************************************************************************

 * @attention

 *

 * Copyright (c) 2023 STMicroelectronics.

 * All rights reserved.

 *

 * This software is licensed under terms that can be found in the LICENSE file

 * in the root directory of this software component.

 * If no LICENSE file comes with this software, it is provided AS-IS.

 *

 ******************************************************************************

 */

/* USER CODE END Header */

/* Includes ------------------------------------------------------------------*/

#include "main.h"

/* Private includes ----------------------------------------------------------*/

/* USER CODE BEGIN Includes */

/* USER CODE END Includes */

/* Private typedef -----------------------------------------------------------*/

/* USER CODE BEGIN PTD */

/* USER CODE END PTD */

#define START_ADDRESS (0x08010000)

/* Private define ------------------------------------------------------------*/

/* USER CODE BEGIN PD */

/* USER CODE END PD */

uint32_t Flash_Data = 19;

uint32_t read;

/* Private macro -------------------------------------------------------------*/

/* USER CODE BEGIN PM */

/* USER CODE END PM */

/* Private variables ---------------------------------------------------------*/

/* USER CODE BEGIN PV */

/* USER CODE END PV */

/* Private function prototypes -----------------------------------------------*/

void SystemClock_Config(void);

/* USER CODE BEGIN PFP */

/* USER CODE END PFP */

/* Private user code ---------------------------------------------------------*/

/* USER CODE BEGIN 0 */

/* USER CODE END 0 */

uint32_t Flash_Write_Data (uint32_t StartPageAddress, uint32_t *Data, uint16_t numberofwords);

void Flash_Read_Data (uint32_t StartPageAddress, uint32_t *RxBuf, uint16_t numberofwords);

/**

 * @brief The application entry point.

 * @retval int

 */

int main(void)

{

 /* USER CODE BEGIN 1 */

 /* USER CODE END 1 */

 /* MCU Configuration--------------------------------------------------------*/

 /* Reset of all peripherals, Initializes the Flash interface and the Systick. */

 HAL_Init();

 /* USER CODE BEGIN Init */

 /* USER CODE END Init */

 /* Configure the system clock */

 SystemClock_Config();

 /* USER CODE BEGIN SysInit */

 /* USER CODE END SysInit */

 /* Initialize all configured peripherals */

 /* USER CODE BEGIN 2 */

 /* USER CODE END 2 */

 Flash_Write_Data(START_ADDRESS, &Flash_Data,1);

 Flash_Read_Data(START_ADDRESS,&read,2);

 /* Infinite loop */

 /* USER CODE BEGIN WHILE */

 while (1)

 {

  /* USER CODE END WHILE */

  /* USER CODE BEGIN 3 */

 }

 /* USER CODE END 3 */

}

/**

 * @brief System Clock Configuration

 * @retval None

 */

void SystemClock_Config(void)

{

 RCC_OscInitTypeDef RCC_OscInitStruct = {0};

 RCC_ClkInitTypeDef RCC_ClkInitStruct = {0};

 /** Configure the main internal regulator output voltage

 */

 HAL_PWREx_ControlVoltageScaling(PWR_REGULATOR_VOLTAGE_SCALE1);

 /** Initializes the RCC Oscillators according to the specified parameters

 * in the RCC_OscInitTypeDef structure.

 */

 RCC_OscInitStruct.OscillatorType = RCC_OSCILLATORTYPE_HSI;

 RCC_OscInitStruct.HSIState = RCC_HSI_ON;

 RCC_OscInitStruct.HSICalibrationValue = RCC_HSICALIBRATION_DEFAULT;

 RCC_OscInitStruct.PLL.PLLState = RCC_PLL_NONE;

 if (HAL_RCC_OscConfig(&RCC_OscInitStruct) != HAL_OK)

 {

  Error_Handler();

 }

 /** Initializes the CPU, AHB and APB buses clocks

 */

 RCC_ClkInitStruct.ClockType = RCC_CLOCKTYPE_HCLK|RCC_CLOCKTYPE_SYSCLK

               |RCC_CLOCKTYPE_PCLK1|RCC_CLOCKTYPE_PCLK2;

 RCC_ClkInitStruct.SYSCLKSource = RCC_SYSCLKSOURCE_HSI;

 RCC_ClkInitStruct.AHBCLKDivider = RCC_SYSCLK_DIV1;

 RCC_ClkInitStruct.APB1CLKDivider = RCC_HCLK_DIV1;

 RCC_ClkInitStruct.APB2CLKDivider = RCC_HCLK_DIV1;

 if (HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_0) != HAL_OK)

 {

  Error_Handler();

 }

}

/* USER CODE BEGIN 4 */

void Flash_Read_Data (uint32_t StartPageAddress, uint32_t *RxBuf, uint16_t numberofwords)

{

while (1)

{

*RxBuf = *(__IO uint32_t *)StartPageAddress;

StartPageAddress += 2;

RxBuf++;

if (!(numberofwords--)) break;

}

}

static uint32_t GetPage(uint32_t Address)

{

 for (int indx=0; indx<128; indx++)

 {

 if((Address < (0x08000000 + (FLASH_PAGE_SIZE *(indx+1))) ) && (Address >= (0x08000000 + FLASH_PAGE_SIZE*indx)))

 {

 return (0x08000000 + FLASH_PAGE_SIZE*indx);

 }

 }

 return 0;

}

uint8_t bytes_temp[4];

uint32_t Flash_Write_Data (uint32_t StartPageAddress, uint32_t *Data, uint16_t numberofwords)

{

static FLASH_EraseInitTypeDef EraseInitStruct;

uint32_t PAGEError;

int sofar=0;

 /* Unlock the Flash to enable the flash control register access *************/

  HAL_FLASH_Unlock();

  /* Erase the user Flash area*/

 uint32_t StartPage = GetPage(StartPageAddress);

 uint32_t EndPageAdress = StartPageAddress + numberofwords*4;

 uint32_t EndPage = GetPage(EndPageAdress);

  /* Fill EraseInit structure*/

  EraseInitStruct.TypeErase  = FLASH_TYPEERASE_PAGES;

  EraseInitStruct.PageAddress = StartPage;

  EraseInitStruct.NbPages   = ((EndPage - StartPage)/FLASH_PAGE_SIZE) +1;

  if (HAL_FLASHEx_Erase(&EraseInitStruct, &PAGEError) != HAL_OK)

  {

   /*Error occurred while page erase.*/

 return HAL_FLASH_GetError ();

  }

  /* Program the user Flash area word by word*/

  while (sofar<numberofwords)

  {

   if (HAL_FLASH_Program(FLASH_TYPEPROGRAM_DOUBLEWORD, StartPageAddress, Data[sofar]) == HAL_OK)

   {

   StartPageAddress += 8; // use StartPageAddress += 2 for half word and 8 for double word

   sofar++;

   }

   else

   {

    /* Error occurred while writing data in Flash memory*/

   return HAL_FLASH_GetError ();

   }

  }

  /* Lock the Flash to disable the flash control register access (recommended

   to protect the FLASH memory against possible unwanted operation) *********/

  HAL_FLASH_Lock();

  return 0;

}

/* USER CODE END 4 */

/**

 * @brief This function is executed in case of error occurrence.

 * @retval None

 */

void Error_Handler(void)

{

 /* USER CODE BEGIN Error_Handler_Debug */

 /* User can add his own implementation to report the HAL error return state */

 __disable_irq();

 while (1)

 {

 }

 /* USER CODE END Error_Handler_Debug */

}

#ifdef USE_FULL_ASSERT

/**

 * @brief Reports the name of the source file and the source line number

 *     where the assert_param error has occurred.

 * @param file: pointer to the source file name

 * @param line: assert_param error line source number

 * @retval None

 */

void assert_failed(uint8_t *file, uint32_t line)

{

 /* USER CODE BEGIN 6 */

 /* User can add his own implementation to report the file name and line number,

   ex: printf("Wrong parameters value: file %s on line %d\r\n", file, line) */

 /* USER CODE END 6 */

}

#endif /* USE_FULL_ASSERT */

5 REPLIES 5
Javier1
Principal

Howdy @SivaP.​ .

Post your code using the proper formating so it looks less like a shampoo ingredient list and more like code.

0693W00000Y7xHVQAZ.png 

furthermore, isntead of pasting your code and expect everyone to chew it you could provide more context, which mcu are you using? was it working before?

we dont need to firmware by ourselves, lets talk
SivaP.
Associate II
#include "main.h"
 
#define START_ADDRESS (0x08010000)
 
uint32_t Flash_Data = 19;
 
uint32_t read;
 
void SystemClock_Config(void);
 
uint32_t Flash_Write_Data (uint32_t StartPageAddress, uint32_t *Data, uint16_t numberofwords);
 
void Flash_Read_Data (uint32_t StartPageAddress, uint32_t *RxBuf, uint16_t numberofwords);
int main(void)
{
 HAL_Init();
 SystemClock_Config();
 
 Flash_Write_Data(START_ADDRESS, &Flash_Data,1);
 
 Flash_Read_Data(START_ADDRESS,&read,2);
 while (1)
{
}
}
 void Flash_Read_Data (uint32_t StartPageAddress, uint32_t *RxBuf, uint16_t numberofwords)
{
while (1)
{
*RxBuf = *(__IO uint32_t *)StartPageAddress;
 
StartPageAddress += 2;
RxBuf++;
 
if (!(numberofwords--)) break;
 
}
}
static uint32_t GetPage(uint32_t Address)
{
 for (int indx=0; indx<128; indx++)
 {
 
 if((Address < (0x08000000 + (FLASH_PAGE_SIZE *(indx+1))) ) && (Address >= (0x08000000 + FLASH_PAGE_SIZE*indx)))
 {
 return (0x08000000 + FLASH_PAGE_SIZE*indx);
 }
 }
 return 0;
}
uint8_t bytes_temp[4];
uint32_t Flash_Write_Data (uint32_t StartPageAddress, uint32_t *Data, uint16_t numberofwords)
{
static FLASH_EraseInitTypeDef EraseInitStruct;
uint32_t PAGEError;
int sofar=0;
 /* Unlock the Flash to enable the flash control register access *************/
  HAL_FLASH_Unlock();
  /* Erase the user Flash area*/
 uint32_t StartPage = GetPage(StartPageAddress);
 uint32_t EndPageAdress = StartPageAddress + numberofwords*4;
 uint32_t EndPage = GetPage(EndPageAdress);
  /* Fill EraseInit structure*/
  EraseInitStruct.TypeErase  = FLASH_TYPEERASE_PAGES;
  EraseInitStruct.PageAddress = StartPage;
  EraseInitStruct.NbPages   = ((EndPage - StartPage)/FLASH_PAGE_SIZE) +1;
  
if (HAL_FLASHEx_Erase(&EraseInitStruct, &PAGEError) != HAL_OK) 
  {
   /*Error occurred while page erase.*/
 return HAL_FLASH_GetError ();
  }
  /* Program the user Flash area word by word*/
  while (sofar<numberofwords)
  {
   if (HAL_FLASH_Program(FLASH_TYPEPROGRAM_DOUBLEWORD, StartPageAddress, Data[sofar]) == HAL_OK)
   {
   StartPageAddress += 8; // use StartPageAddress += 2 for half word and 8 for double word
   sofar++;
   }
   else
   {
    /* Error occurred while writing data in Flash memory*/
   return HAL_FLASH_GetError ();
   }
  }
  /* Lock the Flash to disable the flash control register access (recomended
   to protect the FLASH memory against possible unwanted operation) *********/
  HAL_FLASH_Lock();
  return 0;
}

I am using stm32g431cbu6 mc. Not able to write integer in the register any suggestions where I need to start from ?

jbake_uni
Associate II

just by looking at part of code i see a hangup:

 

 void Flash_Read_Data (uint32_t StartPageAddress, uint32_t *RxBuf, uint16_t numberofwords)
{
while (1)

 

>>  .. any suggestions where I need to start from 

Instrument the code so you understand what's happening, and function are returning errors, without the need to single step or guess.

Make sure your code is doing what you expect.

There should be plenty of FLASH examples for the STM32G4 within the the CubeG4 repository, review.

 

Tips, Buy me a coffee, or three.. PayPal Venmo
Up vote any posts that you find helpful, it shows what's working..