sysmem.c build error in clang

[unsigned_char_array]

When building an STM32CubeMX generated cmake project with clang there are two files that generate errors:

1. sysmem.c
2. the linker script (STM32L431RCTX_FLASH.ld and stm32l476rgtx_flash.ld)

sysmem.c produces the following error:

Core/Src/sysmem.c:30:35: error: use of undeclared identifier 'NULL'
[build] 30 | static uint8_t *__sbrk_heap_end = NULL;

This is caused by the fact that only errno.h and stdint.h are included. None of them officially define NULL. But they probably do in gcc.

sysmem.c can easily be modified by either:

1. including stddef.h or any other header that defines NULL (https://en.cppreference.com/w/c/types/NULL). This is something ST could do.
2. or modifying build to forcebly include such a file in all files (adding "-include stddef.h" to compile command). I did this so I wouldn't have to modify the file (which would get overwritten by regenerating code).But it's kind of a hack.

Linker scmemory region not defined: RAM
[build] >>> _estack = ORIGIN(RAM) + LENGTH(RAM); /* end of "RAM" Ram type memory */ript generates the following errors:

and

[build] ld.lld: error: STM32L431RCTX_FLASH_clang.ld:93: symbol not found: READONLY
[build] ld.lld: error: unable to place section .ARM.extab at file offset [0xFFFFFFFFF8010000, 0xFFFFFFFFF800FFFF]; check your linker script for overflows

Linker script can easily be modified by:

1. putting "Memories definition" at the beginning
2. and removing the "(READONLY)" parts

Modifying sysmem.c would have priority in my opinion since linker scripts often need to be modified anyway.

The resulting code now builds with both clang and gcc without errors (many warnings though, but that is kind of the point for me, so I can run clang-tidy and parse the syntax tree).

[Pavel A.]

About NULL: +1.

Even without clang,  It looks like stdint.h from "mainstream" GNU headers does not define NULL. The following causes error with gcc on rextester:

//gcc 7.4.0
#include  <errno.h>
#include  <stdint.h>
int main(void)
{
    return (int)NULL;
}

NULL is defined in the newlib headers, not portable.

[Saket_Om]

Hello @unsigned_char_array 

The Cmake project generated by STM32CubeMX is typically designed to work with the GNU Arm Embedded Toolchain.

[unsigned_char_array]

I know. But there is a bug in sysmem.c that can be fixed with 1 line of code.

[Pavel A.]

> that can be fixed with 1 line of code.
Sorry but things are not that simple in real life. In order to make any tiny change someone has to open a ticket, fill in a bunch of data. Then it should pass code review, possibly some CI too, then someone else should approve, then build deliverables... like that.

[unsigned_char_array]

I agree 100%. But this extra include shouldn't lead to other problems. If so then those are bugs too. It should be reviewed and tested and automated builds for various projects and targets should pass.Then it should be rolled out (perhaps for only part of the targets initially). If it causes problems with users it can be addressed. So it shouldn't be difficult, just take time. I don't care if it takes several months as long as it is addressed.
I see a future where GCC and Eclipse won't be the default tools anymore.