LwIP_HTTP_Server_Socket_RTOS More sockets opened at once

[JD3]

How to make more socket connectrions work simultaneously? Is it thread safe sockets Lwip made in demo. If I try to make 2 connectrions in two threads they seems to colidate. Its is not possible to keep two at same time.  Thing like this does not work :

// Vlákno pro HTTP server
static void http_server_socket_thread(void *arg) {
    int sock1, sock2, newconn;
    struct sockaddr_in address, remotehost;

    /* create TCP socket for port 80 */
    if ((sock1 = socket(AF_INET, SOCK_STREAM, 0)) < 0) {
        return;
    }

    /* bind to port 80 at any interface */
    address.sin_family = AF_INET;
    address.sin_port = htons(PORT1);
    address.sin_addr.s_addr = INADDR_ANY;

    if (bind(sock1, (struct sockaddr *)&address, sizeof(address)) < 0) {
        return;
    }

    /* listen for incoming connections (TCP listen backlog = 5) */
    listen(sock1, 5);

    /* create TCP socket for port 1028 */
    if ((sock2 = socket(AF_INET, SOCK_STREAM, 0)) < 0) {
        return;
    }

    /* bind to port 1028 at any interface */
    address.sin_port = htons(PORT2);

    if (bind(sock2, (struct sockaddr *)&address, sizeof(address)) < 0) {
        return;
    }

    /* listen for incoming connections (TCP listen backlog = 5) */
    listen(sock2, 5);

    while (1) {
        fd_set fds;
        int maxfd = (sock1 > sock2) ? sock1 : sock2;

        FD_ZERO(&fds);
        FD_SET(sock1, &fds);
        FD_SET(sock2, &fds);

        if (select(maxfd + 1, &fds, NULL, NULL, NULL) < 0) {
            continue;
        }

        if (FD_ISSET(sock1, &fds)) {
            // Accept connection on port 80
            newconn = accept(sock1, (struct sockaddr *)&remotehost, (socklen_t *)&size);
            http_server_serve(newconn);
        }

        if (FD_ISSET(sock2, &fds)) {
            // Accept connection on port 1028
            newconn = accept(sock2, (struct sockaddr *)&remotehost, (socklen_t *)&size);
            http_server_serve(newconn);
        }
    }
}

// Inicializace HTTP serveru (spuštění vlákna)
void http_server_socket_init() {
    sys_thread_new("http", http_server_socket_thread, NULL, DEFAULT_THREAD_STACKSIZE * 2, WEBSERVER_THREAD_PRIO);
}

[STea]

Hello @JD3 ,

You can have multiple sockets opened at one, for this to work properly you need to have the proper configuration allowing for multiple number of sockets in lwipopts.h.

Here's an example of how you might adjust the settings in lwipopts.h:

#define MEMP_NUM_NETCONN 10 // Adjust based on your needs
#define LWIP_SOCKET (1)
#define LWIP_SOCKET_SET_ERRNO (1)
#define LWIP_SOCKET_OFFSET (0)

#define MEMP_NUM_TCP_PCB 10 // Adjust based on your needs
#define MEMP_NUM_TCP_PCB_LISTEN 5 // Adjust based on your needs
#define MEMP_NUM_TCP_SEG 20 // Adjust based on your needs

 this can be done using Netconn or Socket API. check Developing applications on STM32Cube with LwIP TCP/IP stack section 4.2 for more details on how to properly implement your usecase.

BR

[JD3]

Thank for reply. I am using probably older ver but it works best on our custom board if we use 1 tcp and 1 udp.  We already played increasing items in here but not sure if correctly.  Here is setting: 

#ifndef __LWIPOPTS_H__
#define __LWIPOPTS_H__

/**
 * NO_SYS==1: Provides VERY minimal functionality. Otherwise,
 * use lwIP facilities.
 */
#define NO_SYS                  0

/* ---------- Memory options ---------- */
/* MEM_ALIGNMENT: should be set to the alignment of the CPU for which
   lwIP is compiled. 4 byte alignment -> define MEM_ALIGNMENT to 4, 2
   byte alignment -> define MEM_ALIGNMENT to 2. */
#define MEM_ALIGNMENT           4

/* MEM_SIZE: the size of the heap memory. If the application will send
a lot of data that needs to be copied, this should be set high. */
#define MEM_SIZE                (10*1024)

/* MEMP_NUM_PBUF: the number of memp struct pbufs. If the application
   sends a lot of data out of ROM (or other static memory), this
   should be set high. */
#define MEMP_NUM_PBUF           10
/* MEMP_NUM_UDP_PCB: the number of UDP protocol control blocks. One
   per active UDP "connection". */
#define MEMP_NUM_UDP_PCB        6
/* MEMP_NUM_TCP_PCB: the number of simulatenously active TCP
   connections. */
#define MEMP_NUM_TCP_PCB        10
/* MEMP_NUM_TCP_PCB_LISTEN: the number of listening TCP
   connections. */
#define MEMP_NUM_TCP_PCB_LISTEN 5
/* MEMP_NUM_TCP_SEG: the number of simultaneously queued TCP
   segments. */
#define MEMP_NUM_TCP_SEG        12
/* MEMP_NUM_SYS_TIMEOUT: the number of simulateously active
   timeouts. */
#define MEMP_NUM_SYS_TIMEOUT    10


/* ---------- Pbuf options ---------- */
/* PBUF_POOL_SIZE: the number of buffers in the pbuf pool. */
#define PBUF_POOL_SIZE          16 //8

/* PBUF_POOL_BUFSIZE: the size of each pbuf in the pbuf pool. */
#define PBUF_POOL_BUFSIZE       1524


/* ---------- TCP options ---------- */
#define LWIP_TCP                1
#define TCP_TTL                 255

/* Controls if TCP should queue segments that arrive out of
   order. Define to 0 if your device is low on memory. */
#define TCP_QUEUE_OOSEQ         0

/* TCP Maximum segment size. */
#define TCP_MSS                 (1500 - 40)	  /* TCP_MSS = (Ethernet MTU - IP header size - TCP header size) */

/* TCP sender buffer space (bytes). */
#define TCP_SND_BUF             (4*TCP_MSS)

/*  TCP_SND_QUEUELEN: TCP sender buffer space (pbufs). This must be at least
  as much as (2 * TCP_SND_BUF/TCP_MSS) for things to work. */

#define TCP_SND_QUEUELEN        (2* TCP_SND_BUF/TCP_MSS)

/* TCP receive window. */
#define TCP_WND                 (2*TCP_MSS)


/* ---------- ICMP options ---------- */
#define LWIP_ICMP                1


/* ---------- DHCP options ---------- */
#define LWIP_DHCP               1


/* ---------- UDP options ---------- */
#define LWIP_UDP                1
#define UDP_TTL                 255


/* ---------- Statistics options ---------- */
#define LWIP_STATS 0

/* ---------- link callback options ---------- */
/* LWIP_NETIF_LINK_CALLBACK==1: Support a callback function from an interface
 * whenever the link changes (i.e., link down)
 */
#define LWIP_NETIF_LINK_CALLBACK        1

/*
   --------------------------------------
   ---------- Checksum options ----------
   --------------------------------------
*/

/* 
The STM32F4xx allows computing and verifying the IP, UDP, TCP and ICMP checksums by hardware:
 - To use this feature let the following define uncommented.
 - To disable it and process by CPU comment the  the checksum.
*/
#define CHECKSUM_BY_HARDWARE 


#ifdef CHECKSUM_BY_HARDWARE
  /* CHECKSUM_GEN_IP==0: Generate checksums by hardware for outgoing IP packets.*/
  #define CHECKSUM_GEN_IP                 0
  /* CHECKSUM_GEN_UDP==0: Generate checksums by hardware for outgoing UDP packets.*/
  #define CHECKSUM_GEN_UDP                0
  /* CHECKSUM_GEN_TCP==0: Generate checksums by hardware for outgoing TCP packets.*/
  #define CHECKSUM_GEN_TCP                0 
  /* CHECKSUM_CHECK_IP==0: Check checksums by hardware for incoming IP packets.*/
  #define CHECKSUM_CHECK_IP               0
  /* CHECKSUM_CHECK_UDP==0: Check checksums by hardware for incoming UDP packets.*/
  #define CHECKSUM_CHECK_UDP              0
  /* CHECKSUM_CHECK_TCP==0: Check checksums by hardware for incoming TCP packets.*/
  #define CHECKSUM_CHECK_TCP              0
  /* CHECKSUM_CHECK_ICMP==0: Check checksums by hardware for incoming ICMP packets.*/  
  #define CHECKSUM_GEN_ICMP               0
#else
  /* CHECKSUM_GEN_IP==1: Generate checksums in software for outgoing IP packets.*/
  #define CHECKSUM_GEN_IP                 1
  /* CHECKSUM_GEN_UDP==1: Generate checksums in software for outgoing UDP packets.*/
  #define CHECKSUM_GEN_UDP                1
  /* CHECKSUM_GEN_TCP==1: Generate checksums in software for outgoing TCP packets.*/
  #define CHECKSUM_GEN_TCP                1
  /* CHECKSUM_CHECK_IP==1: Check checksums in software for incoming IP packets.*/
  #define CHECKSUM_CHECK_IP               1
  /* CHECKSUM_CHECK_UDP==1: Check checksums in software for incoming UDP packets.*/
  #define CHECKSUM_CHECK_UDP              1
  /* CHECKSUM_CHECK_TCP==1: Check checksums in software for incoming TCP packets.*/
  #define CHECKSUM_CHECK_TCP              1
  /* CHECKSUM_CHECK_ICMP==1: Check checksums by hardware for incoming ICMP packets.*/  
  #define CHECKSUM_GEN_ICMP               1
#endif


/*
   ----------------------------------------------
   ---------- Sequential layer options ----------
   ----------------------------------------------
*/
/**
 * LWIP_NETCONN==1: Enable Netconn API (require to use api_lib.c)
 */
#define LWIP_NETCONN                    1

/*
   ------------------------------------
   ---------- Socket options ----------
   ------------------------------------
*/
/**
 * LWIP_SOCKET==1: Enable Socket API (require to use sockets.c)
 */
#define LWIP_SOCKET                     1

/*
   ------------------------------------
   ---------- httpd options ----------
   ------------------------------------
*/
/** Set this to 1 to include "fsdata_custom.c" instead of "fsdata.c" for the
 * file system (to prevent changing the file included in CVS) */
#define HTTPD_USE_CUSTOM_FSDATA   1

/*
   ---------------------------------
   ---------- OS options ----------
   ---------------------------------
*/

#define TCPIP_THREAD_NAME              "TCP/IP"
#define TCPIP_THREAD_STACKSIZE          1000
#define TCPIP_MBOX_SIZE                 6
#define DEFAULT_UDP_RECVMBOX_SIZE       6
#define DEFAULT_TCP_RECVMBOX_SIZE       6
#define DEFAULT_ACCEPTMBOX_SIZE         6
#define DEFAULT_THREAD_STACKSIZE        500
#define TCPIP_THREAD_PRIO               osPriorityHigh



#endif /* __LWIPOPTS_H__ */

/************************ (C) COPYRIGHT STMicroelectronics *****END OF FILE****/

[STea]

Hello @JD3 ,

It seems to be ok maybe try increasing the stack size if you will be handling multiple sockets on the same thread. I think that you can know have multiple connections implemented.

BR

[JD3]

Hello, thanks. Tried but its same. I think that there is something wront with thread safe, access to connection functions. Hanndling connection probably does not have semphores or something like that. Also that demo where is used TCP and UDP in two threads sometimes looses packets. There must be some bug I think..

[STea]

Hello @JD3 ,

what is the example you are using the UDP and TCP connection can you share the link with us maybe.

Regards