[OTG + CMSIS-mandated device headers] duplicate definitions
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Email to a Friend
- Report Inappropriate Content
‎2017-09-03 7:05 AM
In stm32f407xx.h V2.6.1 14-February-2017 as seen in CubeF4 1.15 and 1.16, the definition section under
/******************** Bit definition for OTG register ********************/
repeats twice (around 2x42 lines).
Moreover, these definitions are duplicating the USB_OTG_GRXSTSP definitions and contrary to the latter they don't appear to be used anywhere else in Cube at all, so IMO both copies can be removed with no consequences whatsoever.
JW
PS. My ever-repeating request for adding non-single-bit bitfield values definitions into the CMSIS-mandated device headers still stands.
Solved! Go to Solution.
Accepted Solutions
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Email to a Friend
- Report Inappropriate Content
‎2017-11-21 2:30 AM
Hello Jan,
/******************** Bit definition for OTG register ********************/
repeats twice (around 2x42 lines).-> The duplicated lines are removed from stm32f407xx.h in
.Moreover, these definitions are duplicating the USB_OTG_GRXSTSP definitions
and contrary to the latter they don't appear to be used anywhere else in Cube at all, so IMO both copies can be removed with no consequences whatsoever.-> Correct! These definitions are duplicating the USB_OTG_GRXSTSP and are not used anywhere is Cube. However, they were used in previous drivers. Our customers who had started working when only those defines were present will be impacted if we remove them. For this reason, those defines will be kept.
Khouloud.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Email to a Friend
- Report Inappropriate Content
‎2017-09-06 9:51 AM
Hi Jan,
- The bit definition for OTG register is repeated twice: The repeated section will be removed from the file on next releases.
Moreover, these definitions are duplicating the USB_OTG_GRXSTSP definitions and contrary to the latter they don't appear to be used anywhere else in Cube at all
-> Those definitions are used on 'stm32f4xx_hal_pcd.c' and 'stm32f4xx_hal_hcd.c' files: They should be kept.
My ever-repeating request for adding non-single-bit bitfield values definitions into the CMSIS-mandated device headers still stands.
-> Could you please give a brief explanation about this. What do you propose to add exactly?
Khouloud.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Email to a Friend
- Report Inappropriate Content
‎2017-09-06 12:17 PM
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Email to a Friend
- Report Inappropriate Content
‎2017-09-07 3:54 AM
Hi Jan,
- You're right. I will check if there's a reason for which they are defined.
It's slightly off-topic here, I'll start a new thread soon.
-> Many thanks. This would be very helpful.
Khouloud.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Email to a Friend
- Report Inappropriate Content
‎2017-11-21 2:30 AM
Hello Jan,
/******************** Bit definition for OTG register ********************/
repeats twice (around 2x42 lines).-> The duplicated lines are removed from stm32f407xx.h in
.Moreover, these definitions are duplicating the USB_OTG_GRXSTSP definitions
and contrary to the latter they don't appear to be used anywhere else in Cube at all, so IMO both copies can be removed with no consequences whatsoever.-> Correct! These definitions are duplicating the USB_OTG_GRXSTSP and are not used anywhere is Cube. However, they were used in previous drivers. Our customers who had started working when only those defines were present will be impacted if we remove them. For this reason, those defines will be kept.
Khouloud.
