Requesting change to HAL_FDCAN_GetProtocolStatus() and FDCAN_COM_*** macros

Rajeev Arora · ‎2020-10-06

Hello,

Please help me with your opinions on my concern which is related with ease of reading and understanding. Please review my last comment that I uploaded to:

https://github.com/STMicroelectronics/STM32CubeH7/issues/62

Regards,

Rajeev

TDK · ‎2020-10-06

It sounds like you got a reasonable response already on Github. There is not a bug, the convention of not right-shifting values is prevalent throughout HAL. You're requesting a change that would break backwards compatibility with limited upside. If I was coding HAL, I would have given the same response.

If you feel a post has answered your question, please click "Accept as Solution".

View solution in original post

TDK · ‎2020-10-06

It sounds like you got a reasonable response already on Github. There is not a bug, the convention of not right-shifting values is prevalent throughout HAL. You're requesting a change that would break backwards compatibility with limited upside. If I was coding HAL, I would have given the same response.

If you feel a post has answered your question, please click "Accept as Solution".