STM32H5 HAL_FLASHEx_OBGetConfig gives incorrect EDATASize

[PieterG]

When I configure 8 EDATA sectors with

FLASH_OBInitStruct.OptionType = OPTIONBYTE_EDATA;
FLASH_OBInitStruct.Banks = FLASH_BANK_1;
FLASH_OBInitStruct.EDATASize = 8;
HAL_FLASHEx_OBProgram(&FLASH_OBInitStruct);

 

and then I read the result:

 

FLASH_OBInitStruct.Banks = FLASH_BANK_1;
HAL_FLASHEx_OBGetConfig(&FLASH_OBInitStruct);

The FLASH_OBInitStruct.EDATASize member has the value 3.

 

This is caused by two issues:

In CMSIS/Device/stm32h563xx.h (and 562xx, 573xx and 503xx as well)

#define FLASH_EDATAR_EDATA_STRT_Msk (0x3UL << FLASH_EDATAR_EDATA_STRT_Pos) /*!< 0x00000003 */

while according to the datasheets this field is 3 bits wide:

I've changed the mask to 0x7.

Now when I read EDATASize, I get the value of 7 (instead of 8).

This is because FLASH_OB_EDATAConfig uses EDATASize - 1, but FLASH_OB_EDATAConfig fails to add 1 to the result.

I've modified FLASH_OB_GetEDATA to add 1 to EDATASize, and also made a check on FLASH_EDATAR_EDATA_EN to avoid that zero FLASH_EDATAR_EDATA_STRT would result in EDATASize being 1:

/* Get configuration of secure area */
if (regvalue & FLASH_EDATAR_EDATA_EN)
{
  *EDATASize = (regvalue & FLASH_EDATAR_EDATA_STRT) + 1;
}

instead of what is currently used:

/* Get configuration of secure area */
*EDATASize = (regvalue & FLASH_EDATAR_EDATA_STRT);

 

Do you think these changes are correct, and if so, could you please apply them to STM32CubeH5?

[FBL]

Hello @PieterG 

Thank you to bring this issue to our attention. An internal ticket 167670 is submitted to update CubeH5.