Skip to main content
Grzegorz Kania
Associate II
June 22, 2018
Question

Error(?) in stm32f7xx_hal_ltdc.h

  • June 22, 2018
  • 1 reply
  • 575 views
Posted on June 22, 2018 at 08:42

Hi,

It seems to me that there is an error in the stm32f7xx_hal_ltdc.h file from STM32Cube_FW_F7_V1.7.0

macro:

#define __HAL_LTDC_GET_IT_SOURCE (__ HANDLE__, __INTERRUPT__) ((__HANDLE __) -> Instance-> ISR & (__INTERRUPT__))

should test the IER register, not the ISR register.

Look at the file stm32f7xx_hal_ltdc.c, the interrupt service function:

void HAL_LTDC_IRQHandler (LTDC_HandleTypeDef * hltdc)

{

   / * Transfer Error Interrupt management *************************************** /

   if (__ HAL_LTDC_GET_FLAG (hltdc, LTDC_FLAG_TE)! = RESET)

   {

     if (__ HAL_LTDC_GET_IT_SOURCE (hltdc, LTDC_IT_TE)! = RESET)

     {

Here, the ISR register is checked twice, and the IER and ISR should.

What do you think about it?

Regards

Grzegorz

    This topic has been closed for replies.

    1 reply

    ST Technical Moderator
    June 22, 2018
    Posted on June 22, 2018 at 15:51

    Hello

    Kania.Grzegorz.002

    ,

    Thank you for bringing this issue to our attention.

    This is raisedinternally for fix in the coming release of STM32CubeF7 firmware package.

    With Regards,

    Imen.

    In order to give better visibility on the answered topics, please click on 'Best answer' on the reply which solved your issue or answered your question. Thanks