HAL geniuses, how does this work?

Ok, so how is it that as a casual user of the HAL I can see the horrific consequences of this code in a blink of an eye?

Observe the delta in

ABS( 

(0x00000000 

/ (HAL_RCC_GetHCLKFreq() / 1000))  )

CLUE: It is a number significantly larger than ONE

This will break code like this, which is completely valid for 32-bit number space,

__weak void HAL_Delay(__IO uint32_t Delay)

and the thousands of other timeout use cases in the entire HAL

Then we have other horrific code like this:

/* Got awaited press state */

/* Is state of the touch changing ? */

Again, someone really doesn't know how to use HAL_GetTick, or basic 32-bit unsigned number space math.

if ((HAL_GetTick() - 100) > TimeStart) // NO NO NO NO NO !!!!!!

This is a more robust solution, one where you don't call functions repeatedly and do division, will all help significantly

For Core Cycle Counter
uint32_t HAL_GetTick(void)
{
 return(DWT->CYCCNT);
}
__weak void HAL_Delay(uint32_t Delay) // In milliseconds, @ 200 MHz stay below 474 seconds
{
 uint32_t tickstart = HAL_GetTick();
 uint32_t wait = Delay * (HAL_RCC_GetHCLKFreq() / 1000); // ms to core ticks
 while((HAL_GetTick() - tickstart) < wait);
}

For 32-bit TIM2 clocking at 1 MHz
uint32_t HAL_GetTick(void)
{
 return(TIM2->CNT);
}
__weak void HAL_Delay(uint32_t Delay) // In milliseconds, @ 1MHz stay below 4967 seconds
{
 uint32_t tickstart = HAL_GetTick();
 uint32_t wait = Delay * 1000; // ms to microseconds
 while((HAL_GetTick() - tickstart) < wait);
}
�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?

And for the other Timeout cases, you should provide a SCALING macro that converts for millisecond units to the units of the Ticker.

Here is a real world example of a woman winning $FFFFFFEC cents

http://www.dailymail.co.uk/news/article-4612826/Woman-told-43million-slot-machine-win-glitch-sues.html

When something is really badly broken it becomes quite hard to even have a meaningful discussion about it. In my experience all time representations must be signed to make time calculations work at all.